RE: [PATCH 08/10] drm/radeon: replace pflip and sw_int counters with atomics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Sylvain BERTRAND [mailto:sylware@xxxxxxxxxx]
> Sent: Thursday, May 24, 2012 1:59 PM
> To: Christian König
> Cc: j.glisse@xxxxxxxxx; Koenig, Christian; dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 08/10] drm/radeon: replace pflip and sw_int counters
> with atomics
> 
> > +	atomic_t			ring_int[RADEON_NUM_RINGS];
> >  	bool
> 	crtc_vblank_int[RADEON_MAX_CRTCS];
> > -	bool				pflip[RADEON_MAX_CRTCS];
> > -	int
> 	pflip_refcount[RADEON_MAX_CRTCS];
> > +	atomic_t			pflip[RADEON_MAX_CRTCS];
> 
> Hi,
> 
> Does the linux API mandates atomic_t to be a 32bits word?

AFAIK it is, at least for the platforms we care about. But since this depends on the vertical refresh frequency even a 8bit counter should do fine.

On the other hand it was an accident that those patches hit the maillinglist in the first place, cause only the first four where supposed to be send out (my fault, sorry). This one isn't tested beside compiling, and I don't think it will work out of the box.

Cheers,
Christian.

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux