On Fri, Oct 11, 2019 at 07:55:36PM +0200, Thomas Zimmermann wrote: > Hi > > Am 11.10.19 um 19:09 schrieb Daniel Stone: > > Hi Rohan, > > > > On Fri, 11 Oct 2019 at 15:30, Rohan Garg <rohan.garg@xxxxxxxxxxxxx> wrote: > > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > > easier to debug issues in userspace applications. > > > > I'm not sure if this was pointed out already, but dumb buffers != GEM > > buffers. GEM buffers _can_ be dumb, but might not be. > > > > Could you please rename to GEM_SET_LABEL? > > This change to build upon dumb buffers was suggested by me, as dumb buffers > is the closes thing there is to a buffer management interface. Drivers with > 'smart buffers' would have to add their own ioctl interfaces. We already have some IOCTLs that apply to gem buffers, not just dumb buffers, so GEM_SET_LABEL seems a lot more reasonable to me, too. > What I really miss here is a userspace application that uses this > functionality. It would be much easier to discuss if there was an actual > example. +1. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
