Hi Emil: These changes are not due to previous bugs. The init code changes for a couple of reasons: During the development of the project, 1: Suppliers of LCDS keep changing the process, optimizing the circuitry, and changing the values of certain registers. 2: Changing display effects, such as color temperature, white balance, gamma values, will also change the values of some registers. 3: 8 and 10 inch devices are different. As they continue to optimize their init code there will be big differences. And we're going to continue to provide an optimized init code. Thanks. Emil Velikov <emil.l.velikov@xxxxxxxxx> 于2019年8月5日周一 下午6:17写道： > > On Sat, 3 Aug 2019 at 15:37, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > > Hi Jerry. > > > > On Sat, Aug 03, 2019 at 10:40:44AM +0800, Jerry Han wrote: > > > V1: https://patchwork.freedesktop.org/patch/287425/ > > > V2: https://patchwork.freedesktop.org/patch/289843/ > > > V3: https://patchwork.freedesktop.org/patch/290393/ > > > V4: https://patchwork.freedesktop.org/patch/290396/ > > > V5: https://patchwork.freedesktop.org/patch/291131/ (only modify > > > commit message Added changelog, no files modified) > > > V6: https://patchwork.freedesktop.org/patch/291650/ > > > V7: https://patchwork.freedesktop.org/patch/294141/ > > > V8: https://patchwork.freedesktop.org/patch/301925/ > > > V9: https://patchwork.freedesktop.org/patch/320514/ > > > > > From 63bcc4f1e72713eca14c4b08e62bc3c07e67904a Mon Sep 17 00:00:00 2001 > > > From: Jerry Han <hanxu5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > Date: Thu, 1 Aug 2019 15:52:35 +0800 > > > Subject: [PATCH 02/10] [v2,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD > > > panel > > > > > > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > > > panel. > > > > > > V2: > > > - Use SPDX identifier (Sam) > > > - Use necessary header files replace drmP.h (Sam) > > > - Delete unnecessary header files #include <linux/err.h> (Sam) > > > - Specifies a GPIOs array to control the reset timing, > > > instead of reading "dsi-reset-sequence" data from DTS (Sam) > > > - Delete backlight_disable() function when already disabled (Sam) > > > - Use devm_of_find_backlight() replace of_find_backlight_by_node() > > > (Sam) > > > - Move the necessary data in the DTS to the current file, > > > like porch, display_mode and Init code etc. (Sam) > > > - Add compatible device "boe,himax8279d10p" (Sam) > > > > > > V1: > > > - Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > > > panel. > > > > Something went wrong when you tried to submit v10. > > Please try again. > > > Apart from that, seems like the init sequence has changed drastically. > > What is the reason behind this? Was there a bug with previous patches? > > For reference in v8 the sequence was nearly identical for 8 and 10 > inch devices - 8-10 line difference. > Now we're looking at ~250 ... > > -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
