Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 08, 2019 at 08:39:11AM -0600, Rob Herring wrote:
> On Thu, Aug 8, 2019 at 7:44 AM Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
> >
> >
> >
> > Gerd Hoffmann (17):
> >   drm/ttm: turn ttm_bo_device.vma_manager into a pointer
> >   drm/ttm: add gem_ttm_bo_device_init()
> >   drm/vram: switch vram helpers to the new gem_ttm_bo_device_init()
> >   drm/qxl: switch qxl to the new gem_ttm_bo_device_init()
> >   drm: add mmap() to drm_gem_object_funcs
> >   drm/shmem: switch shmem helper to drm_gem_object_funcs->mmap
> >   drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS
> >   drm/ttm: factor out ttm_bo_mmap_vma_setup
> >   drm/ttm: add drm_gem_ttm_mmap()
> >   drm/vram: switch vram helper to drm_gem_object_funcs->mmap codepath
> >   drm/vram: drop verify_access
> >   drm: drop DRM_VRAM_MM_FILE_OPERATIONS
> >   drm/qxl: use drm_gem_object_funcs
> >   drm/qxl: drop qxl_ttm_fault
> >   drm/qxl: switch qxl to drm_gem_object_funcs->mmap codepath
> >   drm/qxl: drop verify_access
> >   drm/qxl: use DEFINE_DRM_GEM_FOPS()
> 
> Perhaps instead of changing drivers to use DEFINE_DRM_GEM_FOPS, make
> that the default if .fops is NULL (and perhaps also if the driver sets
> DRIVER_GEM). That would be in line with other recent rework making
> various function ptrs optional.

Not so easy for fops due to .owner = THIS_MODULE

cheers,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux