On Tue, 24 Apr 2012 23:30:22 +0100 Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Tue, Apr 24, 2012 at 11:31:17PM +0100, Alan Cox wrote: > > On Tue, 24 Apr 2012 22:02:18 +0100 > > Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > > The PowerVR Intels I'd seen had the opregion address in the 0xfc > > > register as well. Is this no longer true on the latest? > > > > PowerVR does - i740 never did. > > > > The PowerVR 0xfc poking also doesn't currently work once the driver takes > > over because it isn't yet implementing the driver end of the weird ACPI > > messaging/event stuff. > > > > Once it does the GMA500 will be able to do an ACPI video register, but we > > will still need the check to get the ifdeffery right for what drivers are > > compiled for the kernel. > > Right now you seem to set opregion unconditionally on PVR, which seems > to be equivalent to the 0xfc check that was there before - I can > understand excluding i740, but the PVR check could be left with the gen > hardware one? Not really - they are two drivers. If you build with i915 and not GMA500 you need the opregion for one and the acpi fallback for the other, and vice versa. So we have to check both CONFIG_xxx macro sets. Right now GMA500 needs the ACPI video stuff never to be enabled on some machines. Until we've got full opregion support in the driver that won't change. Alan _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
