| What | Removed | Added |
|---|---|---|
| CC | paulepanter@users.sourceforge.net |
Comment # 16
on bug 107296
from Paul Menzel
Could some AMD developer please comment, on how to fix this? Tables(?)
containing “0 kHz” are apparently shipped by vendors, so what to do?
```
static bool verify_clock_values(struct dm_pp_clock_levels_with_voltage *clks)
{
int i;
if (clks->num_levels == 0)
return false;
for (i = 0; i < clks->num_levels; i++)
/* Ensure that the result is sane */
if (clks->data[i].clocks_in_khz == 0)
return false;
return true;
}
```
Should commit 00893681a0ff4 (drm/amd/display: Reject PPLib clock values if they
are invalid) [1] be reverted? Andrew, Tony, Harry?
> drm/amd/display: Reject PPLib clock values if they are invalid
>
> We should be sticking with the default clock values if the values
> obtained from PPLib are bogus.
>
> Signed-off-by: Andrew Jiang <Andrew.Jiang@amd.com>
> Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
> Acked-by: Harry Wentland <harry.wentland@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
PS: AMDGPU’s commit messages are too terse, and should be more elaborate.
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=00893681a0ff41cacecabc3dafe0987593a3d5c5
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
