On Fri, Jul 05, 2019 at 11:44:16AM +0000, james qian wang (Arm Technology China) wrote: > Since the property slave_planes have been removed, to avoid the resource > assignment problem in user disable slave pipeline support temporarily. > > Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@xxxxxxx> I guess the way you have to enumerate the planes listing the slave planes wont just automatically work in any fashion and force a lot more fallbacks to primary plane only. At least until virtualization of plane hw is done. So makes sense to outright disable all the slave plane stuff for now. And I think it's ok to keep all the code still, we'll use it again. Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c > index f4400788ab94..8ee879ee3ddc 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c > @@ -481,7 +481,7 @@ int komeda_kms_setup_crtcs(struct komeda_kms_dev *kms, > master = mdev->pipelines[i]; > > crtc->master = master; > - crtc->slave = komeda_pipeline_get_slave(master); This might cause an unused function warning, might need to annotate it with __unused. -Daniel > + crtc->slave = NULL; > > if (crtc->slave) > sprintf(str, "pipe-%d", crtc->slave->id); > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
