On Wed, Jul 3, 2019 at 5:54 AM Daniel Vetter <daniel@xxxxxxxx> wrote:
>
> On Tue, Jul 02, 2019 at 08:57:05PM -0500, Alex Deucher wrote:
> > Hi Dave, Daniel,
> >
> > 3 fixes all cc'ed to stable. Note that dim complains about the Fixes tag
> > in one of the patches. The patch has:
> > Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
> > while dim recommends:
>
> This is the right format.
>
> > Fixes: commit 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
>
> Adding a "commit" is wrong. And at least my dim here doesn't complain
> about your pull. How did you test this?
dim checkpatch 665d6d4e32313a7952bb3339647f74c3a6b0d78a
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style
'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit
921935dc6404 ("drm/amd/powerplay: enforce display related settings
only on needed")'
#8:
921935dc6404 ("drm/amd/powerplay: enforce display related settings
only on needed")
Alex
> -Daniel
>
> > I feel like the former is the more common nomencleture (at least historically),
> > but I'm happy to respin if you'd prefer.
> >
> > The following changes since commit 665d6d4e32313a7952bb3339647f74c3a6b0d78a:
> >
> > Merge tag 'drm-misc-fixes-2019-06-26' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-06-27 11:34:52 +1000)
> >
> > are available in the Git repository at:
> >
> > git://people.freedesktop.org/~agd5f/linux tags/drm-fixes-5.2-2019-07-02
> >
> > for you to fetch changes up to 25f09f858835b0e9a06213811031190a17d8ab78:
> >
> > drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE (2019-07-01 12:16:26 -0500)
> >
> > ----------------------------------------------------------------
> > drm-fixes-5.2-2019-07-02:
> >
> > Fixes for stable
> >
> > amdgpu:
> > - stability fix for gfx9
> > - regression fix for HG on some polaris boards
> > - crash fix for some new OEM boards
> >
> > ----------------------------------------------------------------
> > Alex Deucher (1):
> > drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE
> >
> > Evan Quan (1):
> > drm/amd/powerplay: use hardware fan control if no powerplay fan table
> >
> > Lyude Paul (1):
> > drm/amdgpu: Don't skip display settings in hwmgr_resume()
> >
> > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19 -------------------
> > drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +-
> > .../drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +++-
> > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 +
> > .../gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 4 ++++
> > 5 files changed, 9 insertions(+), 21 deletions(-)
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
