Hi
Am 28.06.19 um 18:55 schrieb Daniel Vetter:
> On Fri, Jun 28, 2019 at 02:26:58PM +0200, Thomas Zimmermann wrote:
>> The GEM object's free function is now called through
>> struct drm_gem_object_funcs.free.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
>> ---
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>> index ce89e56937b0..0efccf365101 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>> @@ -51,8 +51,6 @@ static struct drm_driver hibmc_driver = {
>> .desc = "hibmc drm driver",
>> .major = 1,
>> .minor = 0,
>> - .gem_free_object_unlocked =
>> - drm_gem_vram_driver_gem_free_object_unlocked,
>> .dumb_create = hibmc_dumb_create,
>> .dumb_map_offset = drm_gem_vram_driver_dumb_mmap_offset,
>
> This one looks like it could removed too?
Removing it requires a bit more work on the related fop's mmap function.
Probably something for a separate patch.
Best regards
Thomas
> And then you can ditch the
> EXPORT_SYMBOL and kerneldoc for that one too I think. Anyway good
> follow-up. On the series:
>
> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>
> But it's too hot here, so maybe only count that as an ack :-)
>
> Cheers, Daniel
>
>> .irq_handler = hibmc_drm_interrupt,
>> --
>> 2.21.0
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
