On Fri, Jun 28, 2019 at 3:49 AM Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > > > static inline struct virtio_gpu_object* > > > virtio_gpu_object_ref(struct virtio_gpu_object *bo) > > > The last users of these two helpers are removed with this patch. We > > can remove them. > > patch 12/12 does that. I meant virtio_gpu_object_ref/unref, which are still around after patch 12. > > > > + bo = gem_to_virtio_gpu_obj(&shmem_obj->base); > > > + bo->base.base.funcs = &virtio_gpu_gem_funcs; > > Move this to virtio_gpu_create_object. > > Fixed. > > > > + ret = drm_gem_shmem_pin(&obj->base.base); > > The bo is attached for its entire lifetime, at least currently. Maybe > > we can use drm_gem_shmem_get_pages_sgt (and get rid of obj->pages). > > Already checked this. > We can't due to the iommu quirks. > > cheers, > Gerd > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
