Am Dienstag, den 11.06.2019, 12:26 -0300 schrieb Fabio Estevam:
> dev_info() is more appropriate for printing _info level messages
> inside drivers, so switch to dev_info().
This renders the output quite inconsistent between the hexdumps and the
related messages you are changing here. I do not see this as an
improvement.
Regards,
Lucas
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
> Changes since v1:
> - Adjust commit log to say "_info level" instead of "error"
>
> drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_buffer.c b/drivers/gpu/drm/etnaviv/etnaviv_buffer.c
> index 160ce3c060a5..827b5e42dbe3 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_buffer.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_buffer.c
> @@ -414,18 +414,18 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,
> > buffer->user_size - 4);
>
> > if (drm_debug & DRM_UT_DRIVER)
> > - pr_info("stream link to 0x%08x @ 0x%08x %p\n",
> > - return_target, etnaviv_cmdbuf_get_va(cmdbuf),
> > - cmdbuf->vaddr);
> > + dev_info(gpu->dev, "stream link to 0x%08x @ 0x%08x %p\n",
> > + return_target, etnaviv_cmdbuf_get_va(cmdbuf),
> > + cmdbuf->vaddr);
>
> > if (drm_debug & DRM_UT_DRIVER) {
> > print_hex_dump(KERN_INFO, "cmd ", DUMP_PREFIX_OFFSET, 16, 4,
> > cmdbuf->vaddr, cmdbuf->size, 0);
>
> > - pr_info("link op: %p\n", buffer->vaddr + waitlink_offset);
> > - pr_info("addr: 0x%08x\n", link_target);
> > - pr_info("back: 0x%08x\n", return_target);
> > - pr_info("event: %d\n", event);
> > + dev_info(gpu->dev, "link op: %p\n", buffer->vaddr + waitlink_offset);
> > + dev_info(gpu->dev, "addr: 0x%08x\n", link_target);
> > + dev_info(gpu->dev, "back: 0x%08x\n", return_target);
> > + dev_info(gpu->dev, "event: %d\n", event);
> > }
>
> > /*
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
