Hi. This looks good except one comment about the ioctl. On Mon, Jun 24, 2019 at 6:03 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > ... > +static long cec_adap_g_connector_info(struct cec_adapter *adap, > + struct cec_log_addrs __user *parg) > +{ > + if (!(adap->capabilities & CEC_CAP_CONNECTOR_INFO)) > + return -ENOTTY; I guess access to adap->conn_info needs to be guarded by the lock now. > + if (copy_to_user(parg, &adap->conn_info, > + sizeof(adap->conn_info))) > + return -EFAULT; > + return 0; > +} Best regards. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel