Re: [PATCH v4 2/2] drm/exynos: trigger build of all modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



HI Sam,

2019년 6월 22일 (토) 오후 8:56, Sam Ravnborg <sam@xxxxxxxxxxxx>님이 작성:
>
> Add COMPILE_TEST dependency to force exynos driver to
> built for more than arm and to built modules
> that otherwise required other symbols to be de-selected.
>
> This will increase build coverage of the exynos driver
> thus allowing most trivial build errors to be detected/fixed early.
>
> This introduces one warning when built using sh:
> exynos7_drm_decon.c: In function ‘decon_remove’:
> exynos7_drm_decon.c:769:24: warning: unused variable ‘ctx’
>   struct decon_context *ctx = dev_get_drvdata(&pdev->dev);
>
> This is due to the definition of iounmap() in sh,
> and nothing that exynos driver can fix.
>
> Include fix of exynos build for alpha.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Inki Dae <inki.dae@xxxxxxxxxxx>
> Cc: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> Cc: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> ---
>  drivers/gpu/drm/exynos/Kconfig            | 6 +++---
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 +
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> index cbe58d307d1c..60ce4a8ad9e1 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config DRM_EXYNOS
>         tristate "DRM Support for Samsung SoC EXYNOS Series"
> -       depends on OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM)
> +       depends on OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST)
>         select DRM_KMS_HELPER
>         select VIDEOMODE_HELPERS
>         select SND_SOC_HDMI_CODEC if SND_SOC
> @@ -86,7 +86,7 @@ comment "Sub-drivers"
>
>  config DRM_EXYNOS_G2D
>         bool "G2D"
> -       depends on VIDEO_SAMSUNG_S5P_G2D=n
> +       depends on VIDEO_SAMSUNG_S5P_G2D=n || COMPILE_TEST
>         select FRAME_VECTOR
>         help
>           Choose this option if you want to use Exynos G2D for DRM.
> @@ -114,7 +114,7 @@ config DRM_EXYNOS_SCALER
>
>  config DRM_EXYNOS_GSC
>         bool "GScaler"
> -       depends on VIDEO_SAMSUNG_EXYNOS_GSC=n
> +       depends on VIDEO_SAMSUNG_EXYNOS_GSC=n || COMPILE_TEST
>         select DRM_EXYNOS_IPP
>         help
>           Choose this option if you want to use Exynos GSC for DRM.
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index aefcd624fe32..b0877b97291c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -10,6 +10,7 @@
>
>  #include <linux/console.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/vmalloc.h>

Is this change related to this patch?

Thanks,
Inki Dae

>
>  #include <drm/drm_crtc.h>
>  #include <drm/drm_fb_helper.h>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux