Hi Krzysztof. > > Build tested using allyesconfig, allmodconfig for various > > architectures. > > Hi, > > Thanks for fixes. Just for the record, allyesconfig/allmodconfig are > not a proper way for build test specific drivers. They are nice but > since all dependencies are in, they might miss a lot. You should build > mentioned platform (exynos_defconfig on ARMv7, defconfig on ARMv8) and > multi configs (multi_v7 on ARMv7). Such rule is also valid for other > drivers, not specific to Exynos. Thanks for the feedback. I have added exynos_defconfig, multi_v7_defconfig to my growing list of configs that I try when doing cross driver changes. They include defconfig + allnoconfig for the supported archs too. None of these configs would have triggered a build of exynos_drm_g2d.c so to do that some manual twaeks of the confg was necessary. Adding a COMPILE_TEST dependency will enable the build for the allyesconfig, allmodconfig. Thats worths to consider to avoid future mistakes. Sam Something like this: >From 9b29b85f25f4cc485f36efb8d658766fa9a252d9 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <sam@xxxxxxxxxxxx> Date: Sat, 22 Jun 2019 09:24:06 +0200 Subject: [PATCH v1] drm/exynos: trigger build of all modules Add COMPILE_TEST dependency to a few options to trigger that the modules get built using allyesconfig, allmodconfig. This allows a non-exynos developer to catch build issues in files that is usually not built. Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Cc: Inki Dae <inki.dae@xxxxxxxxxxx> Cc: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> Cc: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> Cc: David Airlie <airlied@xxxxxxxx> Cc: Daniel Vetter <daniel@xxxxxxxx> Cc: Kukjin Kim <kgene@xxxxxxxxxx> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Cc: Jingoo Han <jingoohan1@xxxxxxxxx> --- drivers/gpu/drm/exynos/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index cbe58d307d1c..eadea2daf1ab 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -86,7 +86,7 @@ comment "Sub-drivers" config DRM_EXYNOS_G2D bool "G2D" - depends on VIDEO_SAMSUNG_S5P_G2D=n + depends on VIDEO_SAMSUNG_S5P_G2D=n || COMPILE_TEST select FRAME_VECTOR help Choose this option if you want to use Exynos G2D for DRM. @@ -114,7 +114,7 @@ config DRM_EXYNOS_SCALER config DRM_EXYNOS_GSC bool "GScaler" - depends on VIDEO_SAMSUNG_EXYNOS_GSC=n + depends on VIDEO_SAMSUNG_EXYNOS_GSC=n || COMPILE_TEST select DRM_EXYNOS_IPP help Choose this option if you want to use Exynos GSC for DRM. -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
