Forwarding the review from Alex for this patch that happened "behind the
scenes" before I sent it.
-- Ilija
Date: Thu, 19 Apr 2012 16:14:14 +0000
From: "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>
To: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx>
Subject: RE: ObjectID and encoder_names, possible bug ?
Ah, Ok. Feel free to add my:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
To patch 0002. For patch 1, I'd prefer to keep it as is, since that code
comes from upstream internally so I'd prefer to keep it as close as
possible
for future merges.
Thanks!
Alex
-----Original Message-----
From: Ilija Hadzic [mailto:ihadzic@xxxxxxxxxxxxxxxxxxxxxx]
Sent: Thursday, April 19, 2012 12:09 PM
To: Deucher, Alexander
Subject: RE: ObjectID and encoder_names, possible bug ?
For reference, two patches that I believe address my questions.
-- Ilija
-----Original Message-----
From: Ilija Hadzic [mailto:ihadzic@xxxxxxxxxxxxxxxxxxxxxx]
Sent: Wednesday, April 18, 2012 3:23 PM
To: Deucher, Alexander
Subject: ObjectID and encoder_names, possible bug ?
Hi Alex,
Is this intentional that ENCODER_OBJECT_ID_ALMOND and
ENCODER_OBJECT_ID_NUTMEG are the same in ObjectID.h (they are both
0x22).
There is no ALMOND. It could be removed.
Also, I think that there is a missing entry in encoder_names for
INTERNAL_VCE. Its code is 0x24, so that would be the index=36 entry in
the
table which is missing (the table has only 36 entries).
What table are you talking about?
Alex
On Thu, 19 Apr 2012, Ilija Hadzic wrote:
An entry for INTERNAL_VCE encoder was missing. Add it.
Signed-off-by: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/radeon/radeon_display.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 8086c96..0a1d4bd 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -533,7 +533,7 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
radeon_legacy_init_crtc(dev, radeon_crtc);
}
-static const char *encoder_names[36] = {
+static const char *encoder_names[37] = {
"NONE",
"INTERNAL_LVDS",
"INTERNAL_TMDS1",
@@ -570,6 +570,7 @@ static const char *encoder_names[36] = {
"INTERNAL_UNIPHY2",
"NUTMEG",
"TRAVIS",
+ "INTERNAL_VCE"
};
static const char *connector_names[15] = {
--
1.7.8.5
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
