On Fri, Jun 21, 2019 at 1:15 PM Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote: > > > On 6/17/19 2:47 PM, Arnd Bergmann wrote: > > Building an allmodconfig kernel now produces a harmless warning: > > > > drivers/video/fbdev/pvr2fb.c:726:12: error: unused function 'pvr2_get_param_val' [-Werror,-Wunused-function] > > > > Shut this up the same way as we do for other unused functions > > in the same file, using the __maybe_unused attribute. > > > > Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support") > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Thanks but I've fixed it already by adding #ifndef MODULE (since other > functions in the same file using __maybe_unused depend on either PCI or > SH_DREAMCAST I've preferred not to use this attribute): > > https://marc.info/?l=linux-fbdev&m=156050904010778&w=2 Ok, dropping my patch from the local queue, your version is obviously correct as well. Arnd _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel