HI,
2019년 6월 8일 (토) 오후 5:35, Sam Ravnborg <sam@xxxxxxxxxxxx>님이 작성:
>
> Drop use of the deprecated drmP.h file.
> Replace with forwards / externals as appropriate.
>
> While touching the list of include files divide
> them up in blocks and sort them.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Inki Dae <inki.dae@xxxxxxxxxxx>
> Cc: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> Cc: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 7 +++-
> drivers/gpu/drm/exynos/exynos7_drm_decon.c | 8 ++--
> drivers/gpu/drm/exynos/exynos_dp.c | 13 +++---
> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +-
> drivers/gpu/drm/exynos/exynos_drm_dma.c | 6 ++-
> drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 ++--
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 +++---
> drivers/gpu/drm/exynos/exynos_drm_drv.h | 8 +++-
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 21 +++++-----
> drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +--
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 7 ++--
> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 15 +++----
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 14 ++++---
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 8 ++--
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 7 ++--
> drivers/gpu/drm/exynos/exynos_drm_gsc.c | 13 +++---
> drivers/gpu/drm/exynos/exynos_drm_ipp.c | 3 +-
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 22 +++++-----
> drivers/gpu/drm/exynos/exynos_drm_plane.c | 4 +-
> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 10 ++---
> drivers/gpu/drm/exynos/exynos_drm_scaler.c | 12 +++---
> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 9 ++--
> drivers/gpu/drm/exynos/exynos_hdmi.c | 41 +++++++++----------
> drivers/gpu/drm/exynos/exynos_mixer.c | 31 +++++++-------
> 24 files changed, 151 insertions(+), 136 deletions(-)
>
--- snip ---
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index c20b3a759370..ff9342737a51 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -7,21 +7,21 @@
> * published by the Free Software Foundationr
> */
>
> -#include <linux/kernel.h>
> #include <linux/clk.h>
> #include <linux/component.h>
> +#include <linux/dma-mapping.h>
> #include <linux/err.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/of.h>
>
> -#include <drm/drmP.h>
> #include <drm/exynos_drm.h>
> +
With this patch, many build errors happen.
Seems you missed to include below header files,
<linux/uaccess.h>
<linux/delay.h>
<drm/drm_file.h>
Thanks,
Inki Dae
[Error log]
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
drivers/gpu/drm/exynos/exynos_drm_g2d.c:196:27: error: field ‘base’
has incomplete type
struct drm_pending_event base;
^~~~
drivers/gpu/drm/exynos/exynos_drm_g2d.c: In function ‘g2d_userptr_get_dma_addr’:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:421:50: error: dereferencing
pointer to incomplete type ‘struct drm_file’
struct drm_exynos_file_private *file_priv = filp->driver_priv;
^~
drivers/gpu/drm/exynos/exynos_drm_g2d.c: In function ‘g2d_map_cmdlist_gem’:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:734:8: error: implicit
declaration of function ‘copy_from_user’; did you mean
‘sg_copy_from_buffer’? [-Werror=implicit-function-declaration]
if (copy_from_user(&g2d_userptr, (void __user *)handle,
^~~~~~~~~~~~~~
sg_copy_from_buffer
drivers/gpu/drm/exynos/exynos_drm_g2d.c: In function ‘g2d_finish_event’:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:923:2: error: implicit
declaration of function ‘drm_send_event’; did you mean ‘drm_eld_mnl’?
[-Werror=implicit-function-declaration]
drm_send_event(drm_dev, &e->base);
^~~~~~~~~~~~~~
drm_eld_mnl
drivers/gpu/drm/exynos/exynos_drm_g2d.c: In function ‘g2d_wait_finish’:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:990:3: error: implicit
declaration of function ‘mdelay’
[-Werror=implicit-function-declaration]
mdelay(10);
^~~~~~
drivers/gpu/drm/exynos/exynos_drm_g2d.c: In function
‘exynos_g2d_set_cmdlist_ioctl’:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:1174:9: error: implicit
declaration of function ‘drm_event_reserve_init’; did you mean
‘drm_mm_reserve_node’? [-Werror=implicit-function-declaration]
ret = drm_event_reserve_init(drm_dev, file, &e->base, &e->event.base);
^~~~~~~~~~~~~~~~~~~~~~
drm_mm_reserve_node
drivers/gpu/drm/exynos/exynos_drm_g2d.c:1285:3: error: implicit
declaration of function ‘drm_event_cancel_free’; did you mean
‘drm_gem_object_free’? [-Werror=implicit-function-declaration]
drm_event_cancel_free(drm_dev, &node->event->base);
^~~~~~~~~~~~~~~~~~~~~
drm_gem_object_free
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
