Hi Robert, thank you for the patch. On Tue, 2019-06-18 at 16:50 +0100, Robert Beckett wrote: > Notify drm core before sending pending events during crtc disable. > This fixes the first event after disable having an old stale timestamp > by having drm_crtc_vblank_off update the timestamp to now. > > This was seen while debugging weston log message: > Warning: computed repaint delay is insane: -8212 msec > Would you say this Fixes: a474478642d5 ("drm/imx: fix crtc vblank state regression") ? > Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/imx/ipuv3-crtc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c > index 9cc1d678674f..c436a28d50e4 100644 > --- a/drivers/gpu/drm/imx/ipuv3-crtc.c > +++ b/drivers/gpu/drm/imx/ipuv3-crtc.c > @@ -91,14 +91,14 @@ static void ipu_crtc_atomic_disable(struct drm_crtc *crtc, > ipu_dc_disable(ipu); > ipu_prg_disable(ipu); > > + drm_crtc_vblank_off(crtc); > + This is explained in the commit message and aligns with the drm_crtc_state @event documentation. > spin_lock_irq(&crtc->dev->event_lock); > - if (crtc->state->event) { > + if (crtc->state->event && !crtc->state->active) { This is not mentioned though. If the pending event is not sent here, I assume it will be picked up by .atomic_flush and will then be sent after the first EOF interrupt after the modeset is complete. Can you explain this in the commit message? With that, Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > drm_crtc_send_vblank_event(crtc, crtc->state->event); > crtc->state->event = NULL; > } > spin_unlock_irq(&crtc->dev->event_lock); > - > - drm_crtc_vblank_off(crtc); > } > > static void imx_drm_crtc_reset(struct drm_crtc *crtc) regards Philipp _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel