Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 18, 2019 at 3:27 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Sat, 15 Jun 2019 at 01:57, Joseph Kogut <joseph.kogut@xxxxxxxxx> wrote:
> >
> > Add device tree node for mali gpu on Odroid XU3 SoCs.
> >
> > Signed-off-by: Joseph Kogut <joseph.kogut@xxxxxxxxx>
> > ---
> >
> > Changes v1 -> v2:
> > - Use interrupt name ordering from binding doc
> > - Specify a single clock for GPU node
> > - Add gpu opp table
> > - Fix warnings from IRQ_TYPE_NONE
> >
> >  .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26 +++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> > index 93a48f2dda49..b8a4246e3b37 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> > @@ -48,6 +48,32 @@
> >                 cooling-levels = <0 130 170 230>;
> >         };
> >
> > +       gpu: gpu@11800000 {
> > +               compatible = "samsung,exynos-mali", "arm,mali-t628";
> > +               reg = <0x11800000 0x5000>;
> > +               interrupts = <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> > +                            <GIC_SPI 74  IRQ_TYPE_LEVEL_HIGH>,
> > +                            <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > +               interrupt-names = "job", "mmu", "gpu";
> > +               clocks = <&clock CLK_G3D>;
> > +               mali-supply = <&buck4_reg>;
> > +               operating-points-v2 = <&gpu_opp_table>;
> > +       };
> > +
> > +       gpu_opp_table: gpu-opp-table {
>
> One more thing - use "opp_table" as node name (generic class of node,
> matches style with other tables).

'opp-table' as convention is using '-' rather than '_'.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux