Re: [PULL] topic/remove-fbcon-notifiers for v5.3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 18 Jun 2019, Daniel Vetter wrote:

> On Tue, Jun 18, 2019 at 11:03:47AM +0100, Lee Jones wrote:
> > On Tue, 18 Jun 2019, Maarten Lankhorst wrote:
> > 
> > > Op 14-06-2019 om 11:25 schreef Maarten Lankhorst:
> > > > Hi all,
> > > >
> > > > As discussed with Daniel V, I'm just doing the paperwork here as drm-misc maintainer.
> > > >
> > > > This is the topic pull request for the fbdev notifier removal.
> > > >
> > > > Bar, please make a final check and pull into your fbdev tree.
> > > >
> > > > Lee, please make a final check and pull into your backlight tree.
> > > >
> > > > Greg, this is just fyi, you already acked all the vt and staging patches in here
> > > > to land through other trees.
> > > >
> > > > I'll pull this into drm-misc-next once Bart & Lee acked it.
> > > >
> > > > Cheers, Maarten.
> > > 
> > > Bart, Lee, ping?
> > 
> > Asking for an Ack on a PR is kind of odd.  If you have all of the
> > patch Acks you need, and you've made the PR has small as possible,
> > then you should be good to go.
> 
> Ime there's lots of ways to screw up a pull request, so asking for a "yup
> looks good to me" seems reasonable. I've done that with all the topic
> pulls in the past.

Instead of burdening others, it's probably best to take 'no news is
good news' stance.  In all of the immutable branch PRs I've sent out,
other than the occasional 'pulled thanks', no one has ever reviewed/
acked them before.

> > My plan is to see if any of this collides with my PR to Linus.  If it
> > doesn't then I may not have to pull it in at all.
> 
> For simple conflicts Linus usually prefers to resolve them himself. The
> topic pull is needed if there's more stuff on top, like patches that need
> to be rebased ...

There are multiple uses for immutable branches.  I'll pull this one if
the need arises.

> > > > topic/remove-fbcon-notifiers-2019-06-14-1:
> > > > ----------------------------------------------------------------
> > > > topic/remove-fbcon-notifiers:
> > > > - remove fbdev notifier usage for fbcon, as prep work to clean up the fbcon locking
> > > > - assorted locking checks in vt/console code
> > > > - assorted notifier and cleanups in fbdev and backlight code
> > > >
> > > > The following changes since commit d1fdb6d8f6a4109a4263176c84b899076a5f8008:
> > > >
> > > >   Linux 5.2-rc4 (2019-06-08 20:24:46 -0700)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > >   git://anongit.freedesktop.org/drm/drm-misc tags/topic/remove-fbcon-notifiers-2019-06-14-1
> > > >
> > > > for you to fetch changes up to 1dcff4ae65185e8c0300972f6d8d39d9a9db2bda:
> > > >
> > > >   backlight: simplify lcd notifier (2019-06-13 10:07:20 +0200)
> > > >
> > > > ----------------------------------------------------------------
> > > > Daniel Vetter (33):
> > > >       dummycon: Sprinkle locking checks
> > > >       fbdev: locking check for fb_set_suspend
> > > >       vt: might_sleep() annotation for do_blank_screen
> > > >       vt: More locking checks
> > > >       fbdev/sa1100fb: Remove dead code
> > > >       fbdev/cyber2000: Remove struct display
> > > >       fbdev/aty128fb: Remove dead code
> > > >       fbcon: s/struct display/struct fbcon_display/
> > > >       fbcon: Remove fbcon_has_exited
> > > >       fbcon: call fbcon_fb_(un)registered directly
> > > >       fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify
> > > >       fbdev/omap: sysfs files can't disappear before the device is gone
> > > >       fbdev: sysfs files can't disappear before the device is gone
> > > >       staging/olpc: lock_fb_info can't fail
> > > >       fbdev/atyfb: lock_fb_info can't fail
> > > >       fbdev: lock_fb_info cannot fail
> > > >       fbcon: call fbcon_fb_bind directly
> > > >       fbdev: make unregister/unlink functions not fail
> > > >       fbdev: unify unlink_framebuffer paths
> > > >       fbdev/sh_mob: Remove fb notifier callback
> > > >       fbdev: directly call fbcon_suspended/resumed
> > > >       fbcon: Call fbcon_mode_deleted/new_modelist directly
> > > >       fbdev: Call fbcon_get_requirement directly
> > > >       Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"
> > > >       fbmem: pull fbcon_fb_blanked out of fb_blank
> > > >       fbdev: remove FBINFO_MISC_USEREVENT around fb_blank
> > > >       fb: Flatten control flow in fb_set_var
> > > >       fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls
> > > >       vgaswitcheroo: call fbcon_remap_all directly
> > > >       fbcon: Call con2fb_map functions directly
> > > >       fbcon: Document what I learned about fbcon locking
> > > >       staging/olpc_dcon: Add drm conversion to TODO
> > > >       backlight: simplify lcd notifier
> > > >
> > > >  arch/arm/mach-pxa/am200epd.c                    |  13 +-
> > > >  drivers/gpu/vga/vga_switcheroo.c                |  11 +-
> > > >  drivers/media/pci/ivtv/ivtvfb.c                 |   6 +-
> > > >  drivers/staging/fbtft/fbtft-core.c              |   4 +-
> > > >  drivers/staging/olpc_dcon/TODO                  |   7 +
> > > >  drivers/staging/olpc_dcon/olpc_dcon.c           |   6 +-
> > > >  drivers/tty/vt/vt.c                             |  18 ++
> > > >  drivers/video/backlight/backlight.c             |   2 +-
> > > >  drivers/video/backlight/lcd.c                   |  12 -
> > > >  drivers/video/console/dummycon.c                |   6 +
> > > >  drivers/video/fbdev/aty/aty128fb.c              |  64 ----
> > > >  drivers/video/fbdev/aty/atyfb_base.c            |   3 +-
> > > >  drivers/video/fbdev/core/fbcmap.c               |   6 +-
> > > >  drivers/video/fbdev/core/fbcon.c                | 313 ++++++++-----------
> > > >  drivers/video/fbdev/core/fbcon.h                |   6 +-
> > > >  drivers/video/fbdev/core/fbmem.c                | 399 +++++++++---------------
> > > >  drivers/video/fbdev/core/fbsysfs.c              |  20 +-
> > > >  drivers/video/fbdev/cyber2000fb.c               |   1 -
> > > >  drivers/video/fbdev/neofb.c                     |   9 +-
> > > >  drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c |  21 +-
> > > >  drivers/video/fbdev/sa1100fb.c                  |  25 --
> > > >  drivers/video/fbdev/savage/savagefb_driver.c    |   9 +-
> > > >  drivers/video/fbdev/sh_mobile_lcdcfb.c          | 132 +-------
> > > >  drivers/video/fbdev/sh_mobile_lcdcfb.h          |   5 -
> > > >  include/linux/console_struct.h                  |   5 +-
> > > >  include/linux/fb.h                              |  45 +--
> > > >  include/linux/fbcon.h                           |  30 ++
> > > >  27 files changed, 396 insertions(+), 782 deletions(-)
> > > 
> > > 
> > 
> 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux