Re: [RESEND FOR CI] i915: no need to check return value of debugfs_create functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 Jun 2019, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

And pushed to drm-intel-next-queued, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 323863504111..41386c86ea65 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4442,23 +4442,17 @@ static const struct i915_debugfs_files {
>  int i915_debugfs_register(struct drm_i915_private *dev_priv)
>  {
>  	struct drm_minor *minor = dev_priv->drm.primary;
> -	struct dentry *ent;
>  	int i;
>  
> -	ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
> -				  minor->debugfs_root, to_i915(minor->dev),
> -				  &i915_forcewake_fops);
> -	if (!ent)
> -		return -ENOMEM;
> +	debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
> +			    to_i915(minor->dev), &i915_forcewake_fops);
>  
>  	for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
> -		ent = debugfs_create_file(i915_debugfs_files[i].name,
> -					  S_IRUGO | S_IWUSR,
> -					  minor->debugfs_root,
> -					  to_i915(minor->dev),
> -					  i915_debugfs_files[i].fops);
> -		if (!ent)
> -			return -ENOMEM;
> +		debugfs_create_file(i915_debugfs_files[i].name,
> +				    S_IRUGO | S_IWUSR,
> +				    minor->debugfs_root,
> +				    to_i915(minor->dev),
> +				    i915_debugfs_files[i].fops);
>  	}
>  
>  	return drm_debugfs_create_files(i915_debugfs_list,

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux