On Thu, Jun 13, 2019 at 02:16:16PM +0200, Guido Günther wrote:
> Hi,
> On Thu, Jun 13, 2019 at 01:57:17PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: "Guido Günther" <agx@xxxxxxxxxxx>
> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 14 +++-----------
> > 1 file changed, 3 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > index d88ea8da2ec2..6dcb692c4701 100644
> > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > @@ -257,20 +257,12 @@ static int allpixelson_set(void *data, u64 val)
> > DEFINE_SIMPLE_ATTRIBUTE(allpixelson_fops, NULL,
> > allpixelson_set, "%llu\n");
> >
> > -static int jh057n_debugfs_init(struct jh057n *ctx)
> > +static void jh057n_debugfs_init(struct jh057n *ctx)
> > {
> > - struct dentry *f;
> > -
> > ctx->debugfs = debugfs_create_dir(DRV_NAME, NULL);
> > - if (!ctx->debugfs)
> > - return -ENOMEM;
> >
> > - f = debugfs_create_file("allpixelson", 0600,
> > - ctx->debugfs, ctx, &allpixelson_fops);
> > - if (!f)
> > - return -ENOMEM;
> > -
> > - return 0;
> > + debugfs_create_file("allpixelson", 0600, ctx->debugfs, ctx,
> > + &allpixelson_fops);
> > }
> >
> > static void jh057n_debugfs_remove(struct jh057n *ctx)
>
> Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
Applied to drm-misc-next, thanks.
For the others I'll assume drivers maintainers will pick them up. If not
pls ping/resend and I'll stuff all the remaining ones into drm-misc-next.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
