On Wed, Jun 12, 2019 at 11:19 AM Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > On 12/06/2019 12:12, Daniel Vetter wrote: > > This is a no-op on atomic drivers because with atomic it's simply too > > complicated to get all the locking and workers and nonblocking > > synchronization correct, from essentially an NMI context. Well, too > > complicated = impossible. Also, omapdrm never implemented the > > mode_set_base_atomic hook, so I kinda wonder why this was ever added. > > > > Drop the hooks. > > f9b34a0fa4e25d9c0b72f124680c37c0c38f9934 > > It was just open coding DRM_FB_HELPER_DEFAULT_OPS, to get rid of > "Initializer entry defined twice" warning. > > Acked-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > > Or I can pick it up to my branch if this is not part of a bigger series. Not part of a bigger series, there's still a bunch of real users of this in-tree. Although given how absolutely no one seems to care to make kgdb work on top of atomic drivers I'm hoping I can sunset all this code soon. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
