On 2019.05.26 13:26:33 +0530, Hariprasad Kelam wrote: > Remove duplicate include of trace.h > > Issue identified by includecheck > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gvt/trace_points.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/trace_points.c b/drivers/gpu/drm/i915/gvt/trace_points.c > index a3deed69..569f5e3 100644 > --- a/drivers/gpu/drm/i915/gvt/trace_points.c > +++ b/drivers/gpu/drm/i915/gvt/trace_points.c > @@ -32,5 +32,4 @@ > > #ifndef __CHECKER__ > #define CREATE_TRACE_POINTS > -#include "trace.h" > #endif > -- This actually caused build issue like ERROR: "__tracepoint_gma_index" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_render_mmio" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_gvt_command" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_spt_guest_change" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_gma_translate" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_spt_alloc" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_spt_change" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_oos_sync" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_write_ir" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_propagate_event" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_inject_msi" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_spt_refcount" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_spt_free" [drivers/gpu/drm/i915/i915.ko] undefined! ERROR: "__tracepoint_oos_change" [drivers/gpu/drm/i915/i915.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed Looks we need fix like below. Subject: [PATCH] drm/i915/gvt: remove duplicate include of trace.h This removes duplicate include of trace.h. Found by Hariprasad Kelam with includecheck. Reported-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx> Signed-off-by: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx> --- drivers/gpu/drm/i915/gvt/trace_points.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/trace_points.c b/drivers/gpu/drm/i915/gvt/trace_points.c index a3deed692b9c..fe552e877e09 100644 --- a/drivers/gpu/drm/i915/gvt/trace_points.c +++ b/drivers/gpu/drm/i915/gvt/trace_points.c @@ -28,8 +28,6 @@ * */ -#include "trace.h" - #ifndef __CHECKER__ #define CREATE_TRACE_POINTS #include "trace.h" -- 2.20.1 -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
