Hi Noralf,
On Thu, Apr 18, 2019 at 06:40:42PM +0200, Noralf Trønnes wrote:
> Den 18.04.2019 14.41, skrev Maxime Ripard:
> > + /**
> > + * We want the rotation on the command line to overwrite
> > + * whatever comes from the panel.
> > + */
> > + cmdline = &connector->cmdline_mode;
> > + if (cmdline->specified &&
> > + cmdline->rotation != DRM_MODE_ROTATE_0)
>
> I believe you need to drop that second check, otherwise rotate=0 will
> not overwrite panel rotation.
Good catch :)
> > + } else if (!strncmp(option, "reflect_x", delim - option)) {
> > + rotation |= DRM_MODE_REFLECT_X;
> > + sep = delim;
> > + } else if (!strncmp(option, "reflect_y", delim - option)) {
>
> I think you should drop reflect_x and _y for now since they're not
> supported. People like me that only reads code and not documentation
> (ahem..) will get the impression that this should work.
I'm not sure what you mean here, this is definitely supposed to
work. Is there a limitation you're thinking of?
> Documentation/fb/modedb.txt needs to be updated with this new video= option.
Will do, thanks!
maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
