On Wed, May 22, 2019 at 6:39 AM Steven Price <steven.price@xxxxxxx> wrote: > > On 21/05/2019 19:23, Chris Wilson wrote: > > Quoting Rob Herring (2019-05-21 16:24:27) > >> On Mon, May 20, 2019 at 4:23 AM Steven Price <steven.price@xxxxxxx> wrote: > >>> > >> > >> You forgot to update the subject. I can fixup when applying, but I'd > >> like an ack from Chris on patch 1. > > Sorry about that - I'll try to be more careful in the future. > > > I still think it is incorrect as the limitation is purely an issue with > > the shmem backend and not a generic GEM limitation. It matters if you > > Do you prefer the previous version of this series[1] with the shmem helper? > > [1] > https://lore.kernel.org/lkml/20190516141447.46839-1-steven.price@xxxxxxx/ > > Although this isn't a generic GEM limitation it's currently the same > limitation that applies to the 'dumb' drivers as well as shmem backend, > so I'd prefer not implementing two identical functions purely because > this limitation could be removed in the future. In interest of moving this forward, how about some comments in drm_gem_map_offset() explaining the limitations and when it is appropriate to use the function. Rob _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
