Laurent, On Thu, May 16, 2019 at 2:40 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > On Rockchip rk3288-based Chromebooks when you do a suspend/resume > cycle: > > 1. You lose the ability to detect an HDMI device being plugged in. > > 2. If you're using the i2c bus built in to dw_hdmi then it stops > working. > > Let's add a hook to the core dw-hdmi driver so that we can call it in > dw_hdmi-rockchip in the next commit. > > NOTE: the exact set of steps I've done here in resume come from > looking at the normal dw_hdmi init sequence in upstream Linux plus the > sequence that we did in downstream Chrome OS 3.14. Testing show that > it seems to work, but if an extra step is needed or something here is > not needed we could improve it. > > As part of this change we'll refactor the hardware init bits of > dw-hdmi to happen all in one function and all at the same time. Since > we need to init the interrupt mutes before we request the IRQ, this > means moving the hardware init earlier in the function, but there > should be no problems with that. Also as part of this we now > unconditionally init the "i2c" parts of dw-hdmi, but again that ought > to be fine. > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > > Changes in v2: > - No empty stub for suspend (Laurent) > - Refactor to use the same code in probe and resume (Laurent) > - Unconditionally init i2c (seems OK + needed before hdmi->i2c init) > - Combine "init" of i2c and "setup" of i2c (no reason to split) Are you happy with this now? Even if you feel like you don't want to give it a full Reviewed-by, it'd good if you could confirm that I handled your suggestions properly. Thanks! :-) -Doug _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
