On 30/05/2019 00:55, Sebastian Reichel wrote:
Oh sorry, I missed the part that omap_irq_wait_init() actually enables the framedone irq. It should be enough to just drop the warning (and the curly brackets) to keep existing behaviour. The code exits early with the above warning for any existing code (since that does not register a framedone handler). DSI on the other hand does not reach the omap_irq_wait_init() part. Regarding combining the logic: I don't think there is anything to combine right now. It should be possible to simplify the logic after DSI has been converted to drm_panel style, since this will move the update logic for the screen content from the panel driver to DSI core. TLDR: It's enough to remove the warning. Do you need a new submission for this?
Ok. No, I can edit the patch. Nikolaus, are you able to test DSI videomode with these patches? Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
