Hi, Hsin-Yi: On Thu, 2019-05-30 at 10:55 +0800, Hsin-Yi Wang wrote: > On Tue, May 28, 2019 at 4:53 PM CK Hu <ck.hu@xxxxxxxxxxxx> wrote: > > > I think we've already discussed in [1]. I need a reason to understand > > this is hardware behavior or software bug. If this is a software bug, we > > need to fix the bug and code could be symmetric. > > > > [1] > > http://lists.infradead.org/pipermail/linux-mediatek/2019-March/018423.html > > > Hi CK, > > Jitao has replied in v2[1] > " > mtk_dsi_start must after dsi full setting. > If you put it in mtk_dsi_ddp_start, mtk_dsi_set_mode won't work. DSI > will keep cmd mode. So you see no irq. > ... > " > > [1] https://lore.kernel.org/patchwork/patch/1052505/#1276270 > > Thanks OK, this looks the hardware behavior, so I would like you to add comment in the code to describe why we need this asymmetric behavior. The description should be clear so that we could know how to modify the code flow in future. Regards, CK _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
