On Tue, May 21, 2019 at 8:17 PM Erico Nunes <nunes.erico@xxxxxxxxx> wrote: > > On Tue, May 21, 2019 at 8:47 AM Koenig, Christian > <Christian.Koenig@xxxxxxx> wrote: > > > > Am 21.05.19 um 01:16 schrieb Erico Nunes: > > > [CAUTION: External Email] > > > > > > After "5918045c4ed4 drm/scheduler: rework job destruction", jobs are > > > only deleted when the timeout handler is able to be cancelled > > > successfully. > > > > > > In case no timeout handler is running (timeout == MAX_SCHEDULE_TIMEOUT), > > > job cleanup would be skipped which may result in memory leaks. > > > > > > Add the handling for the (timeout == MAX_SCHEDULE_TIMEOUT) case in > > > drm_sched_cleanup_jobs. > > > > > > Signed-off-by: Erico Nunes <nunes.erico@xxxxxxxxx> > > > Cc: Christian König <christian.koenig@xxxxxxx> > > > > Reviewed-by: Christian König <christian.koenig@xxxxxxx> > > > > Going to pick that up later today into our internal branch. > > Thanks. I also posted one to set lima to use a real default timeout. > > Is it possible for us to still get at least one of these into a tree > that goes to a linux 5.2-rc? > This issue may make lima unusable as the system runs out of memory > quickly if many opengl programs are launched. > The "drm/scheduler: rework job destruction" commit is not in 5.2-rc. So no need to pick any fix to that place. It would be better that run some tests on 5.2-rc for other possible fixes indeed. Regards, Qiang _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
