Re: [PATCH v1 0/4] drm/gma500: drop use of drmP.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 20, 2019 at 8:41 PM Daniel Vetter <daniel@xxxxxxxx> wrote:
>
> On Sun, May 19, 2019 at 03:51:05PM +0200, Sam Ravnborg wrote:
> > The following patchset remove use of the deprecated drmP.h
> > header file in the gma500 driver.
> > As preparation an empty header file is removed and a dependency on
> > drm_os_linux.h is dropped.
> > The list of include files are sorted and is some cases divided
> > up in blocks of linux/* drm/* etc.
> >
> > Build tested with allmodconfig and allyesconfig for x86, arm, alpha and more.
> >
> > Patchset made on top of drm-misc-next
>
> Nice series! On the entire pile:
>
> Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>
> Since gma500 is defacto unmaintained I think that's good enough, as long
> as you don't break anything. Maybe wait a bit before merging it all.

"Odd Fixes" is probably the correct status.

This looks good and runs fine. Thanks.

Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>

>
> Aside, I entirely forgot about drm_os_linux.h. That's another file we
> should kill with fire I think :-) Probably best done macro-by-macro or so
> ...
>
> Cheers, Daniel
> >
> >       Sam
> >
> > Sam Ravnborg (4):
> >       drm/gma500: remove empty gma_drm.h header file
> >       drm/gma500: drop drmP.h from header files
> >       drm/gma500: drop use of DRM_UDELAY wrapper
> >       drm/gma500: drop drmp.h include from all .c files
> >
> >  drivers/gpu/drm/gma500/accel_2d.c             |  2 +-
> >  drivers/gpu/drm/gma500/cdv_device.c           |  5 +++--
> >  drivers/gpu/drm/gma500/cdv_intel_crt.c        |  2 +-
> >  drivers/gpu/drm/gma500/cdv_intel_display.c    |  4 +++-
> >  drivers/gpu/drm/gma500/cdv_intel_dp.c         |  7 ++++---
> >  drivers/gpu/drm/gma500/cdv_intel_hdmi.c       |  5 +++--
> >  drivers/gpu/drm/gma500/cdv_intel_lvds.c       |  5 ++---
> >  drivers/gpu/drm/gma500/framebuffer.c          |  2 +-
> >  drivers/gpu/drm/gma500/framebuffer.h          |  1 -
> >  drivers/gpu/drm/gma500/gem.c                  |  5 +++--
> >  drivers/gpu/drm/gma500/gma_device.c           |  1 -
> >  drivers/gpu/drm/gma500/gma_display.c          |  8 +++++++-
> >  drivers/gpu/drm/gma500/gtt.c                  |  3 ++-
> >  drivers/gpu/drm/gma500/gtt.h                  |  1 -
> >  drivers/gpu/drm/gma500/intel_bios.c           |  4 ++--
> >  drivers/gpu/drm/gma500/intel_bios.h           |  3 +--
> >  drivers/gpu/drm/gma500/intel_gmbus.c          |  9 +++++----
> >  drivers/gpu/drm/gma500/intel_i2c.c            |  3 ++-
> >  drivers/gpu/drm/gma500/mdfld_device.c         |  6 ++++--
> >  drivers/gpu/drm/gma500/mdfld_dsi_dpi.c        |  2 ++
> >  drivers/gpu/drm/gma500/mdfld_dsi_output.c     |  5 +++--
> >  drivers/gpu/drm/gma500/mdfld_dsi_output.h     |  2 +-
> >  drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c |  2 ++
> >  drivers/gpu/drm/gma500/mdfld_intel_display.c  |  5 ++++-
> >  drivers/gpu/drm/gma500/mdfld_tmd_vid.c        |  2 ++
> >  drivers/gpu/drm/gma500/mid_bios.c             |  3 +--
> >  drivers/gpu/drm/gma500/mmu.c                  |  4 +++-
> >  drivers/gpu/drm/gma500/oaktrail_crtc.c        |  4 +++-
> >  drivers/gpu/drm/gma500/oaktrail_device.c      |  7 ++++---
> >  drivers/gpu/drm/gma500/oaktrail_hdmi.c        |  6 ++++--
> >  drivers/gpu/drm/gma500/oaktrail_lvds.c        |  4 ++--
> >  drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c    |  1 -
> >  drivers/gpu/drm/gma500/power.h                |  4 +++-
> >  drivers/gpu/drm/gma500/psb_device.c           |  4 ++--
> >  drivers/gpu/drm/gma500/psb_drv.c              | 26 +++++++++++++++++---------
> >  drivers/gpu/drm/gma500/psb_drv.h              |  4 ++--
> >  drivers/gpu/drm/gma500/psb_intel_display.c    |  3 ++-
> >  drivers/gpu/drm/gma500/psb_intel_lvds.c       |  3 +--
> >  drivers/gpu/drm/gma500/psb_intel_modes.c      |  2 +-
> >  drivers/gpu/drm/gma500/psb_intel_sdvo.c       | 10 +++++-----
> >  drivers/gpu/drm/gma500/psb_irq.c              |  3 ++-
> >  drivers/gpu/drm/gma500/psb_irq.h              |  2 +-
> >  drivers/gpu/drm/gma500/psb_lid.c              |  4 ++--
> >  drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c    |  8 +++++---
> >  include/drm/gma_drm.h                         | 25 -------------------------
> >  45 files changed, 118 insertions(+), 103 deletions(-)
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux