Hi Daniel. On Mon, May 20, 2019 at 08:45:26PM +0200, Daniel Vetter wrote: > On Sun, May 19, 2019 at 04:20:30PM +0200, Sam Ravnborg wrote: > > While removing use of drmP.h from files in drm/* I > > noticed that I had to add the same include files due to > > build errors in the header files. > > > > It is better to let the header files include what is necessary > > and let the users pull in only the additional headers files required. > > So I went ahead and made the header files self-conatined. > > (I did not check if this made any includes redundant in some files, > > I do not have tooling in place to do so). > > I think it'd be great to make sure this keeps being the case. Jani Nikula > just pointed me at some neat stuff in drm/i915/Makefile.header-test. > > I think it'd be nice to have something similar for drm headers in > drivers/gpu/drm, behind a Kconfig option perhaps so that it doesn't upset > people, but 0day will still spot issues. That would also make the series > easier to review, since each patch would add the header it fixes to that > build target. I would like to wait with this until Jani's general solution: https://www.spinics.net/lists/linux-kbuild/msg21839.html hits mainline. I can also duplicate what Jani already did and then migrate to the general solution when it is ready. Hmm. I think this is the best way forward. So we can have all the other functionality in place. Let me give this a shot and get back with a few patches. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
