Hi Kieran, Thank you for the patch. On Fri, May 17, 2019 at 10:20:49PM +0100, Kieran Bingham wrote: > The new writeback feature is exports functions so that they can > integrate into the rcar_du_kms module. > > The interface functions are defined in the rcar_du_writeback header, but > it is not included in the object file itself leading to compiler > warnings for missing prototypes. > > Include the header as appropriate. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> And applied to my tree. > --- > drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c > index 989a0be94131..ae07290bba6a 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c > @@ -14,6 +14,7 @@ > #include "rcar_du_crtc.h" > #include "rcar_du_drv.h" > #include "rcar_du_kms.h" > +#include "rcar_du_writeback.h" > > /** > * struct rcar_du_wb_conn_state - Driver-specific writeback connector state -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel