On Thu, May 16, 2019 at 6:33 PM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > On 2019-05-16 2:47 p.m., Daniel Vetter wrote: > > On Thu, May 16, 2019 at 2:46 PM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > >> On 2019-05-16 12:09 p.m., Christian König wrote: > >>> Am 16.05.19 um 10:16 schrieb zhoucm1: > >>>> I was able to push changes to libdrm, but now seems after libdrm is > >>>> migrated to gitlab, I cannot yet. What step do I need to get back my > >>>> permission? I already can login into gitlab with old freedesktop account. > >>>> > >>>> @Christian, Can you help submit this patch set to libdrm first? > >>> > >>> Done. > >> > >> This broke amdgpu-symbol-check: > >> https://gitlab.freedesktop.org/mesa/drm/pipelines/37177 > >> > >> > >> I pushed the trivial fix. Please consider using GitLab MRs, so that the > >> CI pipeline can catch issues like this before they can break the master > >> branch. > > > > Should we switch docs to recommend MR? Make it the default? I guess > > mesa hasn't made them mandatory yet, so doing that for libdrm is a bit > > jumping ahread ... > > Why can't libdrm go first? > > With Mesa, it took some effort to get the CI pipeline to finish in an > acceptable amount of time, but that doesn't seem to be an issue with > libdrm (though it could probably still be sped up somewhat, e.g. by > using pre-generated docker images as in other projects, or just by > passing -j4 to make). tbh I'm all for doing that, just didn't want to mix things up too much :-) And yeah libdrm is small enough that a quick MR-only experiment wont upset anyone if it somehow goes wrong. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
