Hi, On Tue, 14 May 2019 at 17:17, Clément Péron <peron.clem@xxxxxxxxx> wrote: > > Hi, > > On Tue, 14 May 2019 at 12:29, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > > > Hi, > > > > On 13/05/2019 17:14, Daniel Vetter wrote: > > > On Sun, May 12, 2019 at 07:46:00PM +0200, peron.clem@xxxxxxxxx wrote: > > >> From: Clément Péron <peron.clem@xxxxxxxxx> > > >> > > >> Hi, > > >> > > >> The Allwinner H6 has a Mali-T720 MP2. The drivers are > > >> out-of-tree so this series only introduce the dt-bindings. > > > > > > We do have an in-tree midgard driver now (since 5.2). Does this stuff work > > > together with your dt changes here? > > > > No, but it should be easy to add. > I will give it a try and let you know. Added the bus_clock and a ramp delay to the gpu_vdd but the driver fail at probe. [ 3.052919] panfrost 1800000.gpu: clock rate = 432000000 [ 3.058278] panfrost 1800000.gpu: bus_clock rate = 100000000 [ 3.179772] panfrost 1800000.gpu: mali-t720 id 0x720 major 0x1 minor 0x1 status 0x0 [ 3.187432] panfrost 1800000.gpu: features: 00000000,10309e40, issues: 00000000,21054400 [ 3.195531] panfrost 1800000.gpu: Features: L2:0x07110206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002821 AS:0xf JS:0x7 [ 3.207178] panfrost 1800000.gpu: shader_present=0x3 l2_present=0x1 [ 3.238257] panfrost 1800000.gpu: Fatal error during GPU init [ 3.244165] panfrost: probe of 1800000.gpu failed with error -12 The ENOMEM is coming from "panfrost_mmu_init" alloc_io_pgtable_ops(ARM_MALI_LPAE, &pfdev->mmu->pgtbl_cfg, pfdev); Which is due to a check in the pgtable alloc "cfg->ias != 48" arm-lpae io-pgtable: arm_mali_lpae_alloc_pgtable cfg->ias 33 cfg->oas 40 DRI stack is totally new for me, could you give me a little clue about this issue ? Thanks, Clément > > > > > Clément, no need to resend the first patch, it's now on > > linus master. > Ok > > Thanks, > Clement > > > > > Could you also add support for the bus clock in panfrost > > in the same patchset since it's also on master now ? > > > > Neil > > > > > -Daniel > > > > > >> The first patch is from Neil Amstrong and has been already > > >> merged in linux-amlogic. It is required for this series. > > >> > > >> The second patch is from Icenowy Zheng where I changed the > > >> order has required by Rob Herring. > > >> See: https://patchwork.kernel.org/patch/10699829/ > > >> > > >> Thanks, > > >> Clément > > >> > > >> Changes in v4: > > >> - Add Rob Herring reviewed-by tag > > >> - Resent with correct Maintainers > > >> > > >> Changes in v3 (Thanks to Maxime Ripard): > > >> - Reauthor Icenowy for her patch > > >> > > >> Changes in v2 (Thanks to Maxime Ripard): > > >> - Drop GPU OPP Table > > >> - Add clocks and clock-names in required > > >> > > >> Clément Péron (6): > > >> dt-bindings: gpu: mali-midgard: Add H6 mali gpu compatible > > >> arm64: dts: allwinner: Add ARM Mali GPU node for H6 > > >> arm64: dts: allwinner: Add mali GPU supply for Pine H64 > > >> arm64: dts: allwinner: Add mali GPU supply for Beelink GS1 > > >> arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards > > >> arm64: dts: allwinner: Add mali GPU supply for OrangePi 3 > > >> > > >> Icenowy Zheng (1): > > >> dt-bindings: gpu: add bus clock for Mali Midgard GPUs > > >> > > >> Neil Armstrong (1): > > >> dt-bindings: gpu: mali-midgard: Add resets property > > >> > > >> .../bindings/gpu/arm,mali-midgard.txt | 27 +++++++++++++++++++ > > >> .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 5 ++++ > > >> .../dts/allwinner/sun50i-h6-orangepi-3.dts | 5 ++++ > > >> .../dts/allwinner/sun50i-h6-orangepi.dtsi | 5 ++++ > > >> .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 ++++ > > >> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++ > > >> 6 files changed, 61 insertions(+) > > >> > > >> -- > > >> 2.17.1 > > >> > > > > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel