On 21/04/2019 00:25, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Mar 26, 2019 at 12:31:31PM +0200, Tomi Valkeinen wrote:
>> The driver currently sets the video stream registers in
>> tc_main_link_setup. One should be able to establish the DP link without
>> any video stream, so a more logical place is to configure the stream in
>> the tc_main_link_stream. So move them there.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
>> ---
>> drivers/gpu/drm/bridge/tc358767.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
>> index f5c232a9064e..86b272422281 100644
>> --- a/drivers/gpu/drm/bridge/tc358767.c
>> +++ b/drivers/gpu/drm/bridge/tc358767.c
>> @@ -1003,15 +1003,6 @@ static int tc_main_link_setup(struct tc_data *tc)
>> return -EAGAIN;
>> }
>>
>> - ret = tc_set_video_mode(tc, tc->mode);
>> - if (ret)
>> - goto err;
>> -
>> - /* Set M/N */
>> - ret = tc_stream_clock_calc(tc);
>> - if (ret)
>> - goto err;
>> -
>> return 0;
>> err_dpcd_read:
>> dev_err(tc->dev, "Failed to read DPCD: %d\n", ret);
>> @@ -1030,6 +1021,15 @@ static int tc_main_link_stream(struct tc_data *tc, int state)
>> dev_dbg(tc->dev, "stream: %d\n", state);
>>
>> if (state) {
>> + ret = tc_set_video_mode(tc, tc->mode);
>> + if (ret)
>> + goto err;
>> +
>> + /* Set M/N */
>> + ret = tc_stream_clock_calc(tc);
>> + if (ret)
>> + goto err;
>> +
>
> Assuming this change will have a purpose further down in the series,
The purpose is mainly cleanup. The series doesn't go to the point where
the link and the stream could be enabled/disabled independently, but it
tries to separate those functionalities for clarity.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> On a side note you may want to remove the err label in
> tc_stream_clock_calc(), or even inline the write to DP0_VIDMNGEN1 here
> directly.
err label is needed by the tc_write macro. Yes, ugly. There's another
series that cleans those up.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
