On Wed, Apr 24, 2019 at 10:09 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > On Tue, Apr 23, 2019 at 04:20:55PM -0700, John Stultz wrote: > > static int kirin_drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > > - struct drm_plane *plane) > > + struct drm_plane *plane, > > + const struct kirin_drm_data *driver_data) > > Indent looks wrong here. > .. > > ret = drm_universal_plane_init(dev, &kplane->base, 1, > > + driver_data->plane_funcs, > > + driver_data->channel_formats, > > + driver_data->channel_formats_cnt, > > + NULL, type, NULL); > Indent looks wrong here. Thanks! I've now fixed those up. > I missed where ade_driver_data came from. > This looks an extra patch to intoduce driver_data, > that maybe should be merged with an earlier version? I'm not sure I'm following you here. Can you clarify a bit more? thanks -john _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
