Hi John. On Tue, Apr 23, 2019 at 04:20:31PM -0700, John Stultz wrote: > This patchset contains one fix (in the front, so its easier to > eventually backport), and a series of changes from YiPing to > refactor the kirin drm driver so that it can be used on both > kirin620 based devices (like the original HiKey board) as well > as kirin960 based devices (like the HiKey960 board). > > The full kirin960 drm support is still being refactored, but as > this base kirin rework was getting to be substantial, I wanted > to send out the first chunk for some initial review, so that the > review burden wasn't overwhelming. I have been through all 25 patches and it triggered a few minor comments here and there. I know nothing about the hisilicon driver but based on the fact that I know nothing about the driver you can give them all a (smallish) Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> I trust your judgement to decide the feedback you want to address and what to ignore. One request: Could you please in a follow-up patch kill the use of drmP.h. We want to get rid of it one day and three fewer users are one small step towards this goal. Thanks, Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
