Well that is certainly a
NAK because it can lead to deadlock in the
memory management.
You can't just busy wait with all those locks
held.
Regards,
Christian.
Am 23.04.19 um 03:45 schrieb Liang, Prike:
> Acked-by: Prike Liang
<Prike.Liang@xxxxxxx>
>
> Thanks,
> Prike
> -----Original Message-----
> From: Chunming Zhou
<david1.zhou@xxxxxxx>
> Sent: Monday, April 22, 2019 6:39 PM
> To:
dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: Liang, Prike
<Prike.Liang@xxxxxxx>; Zhou,
David(ChunMing)
<David1.Zhou@xxxxxxx>
> Subject: [PATCH] ttm: wait mem space if
user allow while gpu busy
>
> heavy gpu job could occupy memory long
time, which could lead to other user fail to get
memory.
>
> Change-Id:
I0b322d98cd76e5ac32b00462bbae8008d76c5e11
> Signed-off-by: Chunming Zhou
<david1.zhou@xxxxxxx>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2
deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
b/drivers/gpu/drm/ttm/ttm_bo.c index
7c484729f9b2..6c596cc24bec 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -830,8 +830,10 @@ static int
ttm_bo_mem_force_space(struct ttm_buffer_object
*bo,
> if (mem->mm_node)
> break;
> ret =
ttm_mem_evict_first(bdev, mem_type, place, ctx);
> - if (unlikely(ret != 0))
> - return ret;
> + if (unlikely(ret != 0)) {
> + if (!ctx ||
ctx->no_wait_gpu || ret != -EBUSY)
> + return ret;
> + }
> } while (1);
> mem->mem_type = mem_type;
> return ttm_bo_add_move_fence(bo,
man, mem);
> --
> 2.17.1
>
>
_______________________________________________
> dri-devel mailing list
>
dri-devel@xxxxxxxxxxxxxxxxxxxxx
>
https://lists.freedesktop.org/mailman/listinfo/dri-devel