On Tue, Apr 23, 2019 at 08:50:35PM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2019 at 12:00:38PM +1000, Dave Airlie wrote: > > From: Dave Airlie <airlied@xxxxxxxxxx> > > > > This could probably be done with Kconfig somehow, but I failed in my > > first 2 minute attempt. > > > > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx> > > config DRM_ATI_PCIGART > bool > default y > depens on PCI && DRM_LEGACY > > Should give you a nice hidden Kconfig symbol that dtrt and can be used in > the Makefile. With that > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Other option (no idea it's preferred): > > config DRM_ATI_PCIGART > bool > > and then in > > config DRM_LEGACY > select DRM_ATI_PCIGART if PCI > > Either should work I think, the latter more closely follows what we do > already. Personal preference is the latter, because we keep the DRM_LEGACY logic located in one place. But as long as we do it in Kconfig then all is good. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
