On Sat, 20 Apr 2019 at 05:25, John Stultz <john.stultz@xxxxxxxxxx> wrote: > > From: Sean Paul <seanpaul@xxxxxxxxxxxx> > > __mmap2 isn't supported on all platforms, mmap64 is the right way > to do this in android. > > Also folds in a fix from Stéphane Marchesin <marcheu@xxxxxxxxxxxx> > to use an offset in bytes not pages, as that's what mmap64 takes. > > Cc: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx> > Cc: Alistair Strachan <astrachan@xxxxxxxxxx> > Cc: Marissa Wall <marissaw@xxxxxxxxxx> > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> > --- > libdrm_macros.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >From a quick look mmap64 was introduced in bionic with Andoid 5 (Lollipop). A reasonable min. version although we're lacking a check. As a separate commit, copy the PLATFORM_VERSION hunk (or equiv.) from Mesa's Android.mk. Here I'd add a note "introduced with Android L which we require as of earlier commit" and drop the bytes/pages mention. With that this patch is: Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
