Hi, I can try replacing <log/log.h> with <android/log.h>, but I would like to get confirmation from Chih-Wei, the original author of [1] Mauro [1] http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commit;h=9d2a4cc3a16b5b464fda0a0c321dd1f5acadaa33 On Mon, Mar 18, 2019 at 2:32 PM Tapani Pälli <tapani.palli@xxxxxxxxx> wrote: > > > > On 3/18/19 3:25 PM, Robert Foss wrote: > > Hey, > > > > On 3/18/19 2:11 PM, Mauro Rossi wrote: > >> Hi, > >> > >> On Mon, Mar 18, 2019 at 10:58 AM Robert Foss > >> <robert.foss@xxxxxxxxxxxxx> wrote: > >>> > >>> Hey Mauro, > >>> > >>> On 3/18/19 9:38 AM, Mauro Rossi wrote: > >>>> Hi Robert, > >>>> > >>>> On Mon, Mar 18, 2019 at 9:21 AM Robert Foss > >>>> <robert.foss@xxxxxxxxxxxxx> wrote: > >>>>> > >>>>> On a second note, this does not apply on libdrm/master due > >>>>> to: > >>>>> > >>>>> LOCAL_SHARED_LIBRARIES := \ > >>>>> libcutils > >>>> > >>>> Sorry, we have an additional Google patch, not present in libdrm/master > >>>> that adds libdrm_platform module, but it is for a specific Google > >>>> issue. [1] > >>>> > >>>> However with libdrm module we have both liblog and libcutils shared > >>>> dependencies > >>>> > >>>> [1] > >>>> http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commit;h=8ccbfeab9fb2bddf4585339a0bcbea2f1e3ffa1e > >>>> > >>> > >>> Do you know if [1] causes incompatibility issues with earlier android > >>> verions? > >>> If not I would suggest upstreaming it too. > >> > >> I used those patches to build with nougat-x86 and there was no issue. > >> > >> To be precise I did a double rookie mistake, because __android_log_vprint > >> not used in upstream libdrm and libdrm_platform not used either. > >> > >> Now starting from my mistakes, let's see if there is anything useful > >> to libdrm project > >> > >> In our builds Chih-Wei Huang said that libdrm_platform is not used, > >> meaning not added to packages list, > >> however with oreo-x86 the build error appeared and the liblog dependency. > >> > >> __android_log_vprint is used with __ANDROID__ braces > >> in a special patch [2] by Chih-Wei Huang which adds capability to > >> print logs > >> in logcat > >> > >> If it's not too invasive in libdrm, it could be useful. > >> Cheers > >> Mauro > >> > >> [2] > >> http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commitdiff;h=bcee43063ffd52a8677029c9ae6f4203563460f4;hp=81d7264033db4946a00003bf1ee82eb6c21260f9 > >> > > > > [2] Seems like a good idea to me. > > Logcat really is the only intended path for logging on Android, and > > redirecting our logs there does make sense to me. > > > > But, I'm not sure about I like the way [2] disregards log-levels in > > drmMsg(). > > > > Yeah, I think it's a good idea. I see that in mesa we include > "android/log.h", not "log/log.h", will need to make sure we get that > correctly, maybe older versions did "log/log.h"? > > // Tapani _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
