Re: [PATCH 2/2] drm/lima: driver for ARM Mali4xx GPUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 12, 2019 at 6:56 PM Qiang Yu <yuq825@xxxxxxxxx> wrote:
>
> On Tue, Feb 12, 2019 at 11:47 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > On Wed, Feb 6, 2019 at 7:16 AM Qiang Yu <yuq825@xxxxxxxxx> wrote:
> > >
> > > From: Lima Project Developers <lima@xxxxxxxxxxxxxxxxxxxxx>
> >
> > This should be a person (you).
> >
> > > Signed-off-by: Andreas Baierl <ichgeh@xxxxxxxxxxxxx>
> > > Signed-off-by: Erico Nunes <nunes.erico@xxxxxxxxx>
> > > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> > > Signed-off-by: Marek Vasut <marex@xxxxxxx>
> > > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> > > Signed-off-by: Qiang Yu <yuq825@xxxxxxxxx>
> >
> > Being the submitter, your S-o-b should be last.
> >
> > > Signed-off-by: Simon Shields <simon@xxxxxxxxxxxxx>
> > > Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> > > ---

> > > +
> > > +unsigned long lima_timeout_to_jiffies(u64 timeout_ns)
> >
> > Create a common helper instead of copy-n-pasting this from other
> > drivers (etnaviv).
> There's one drm_timeout_abs_to_jiffies but not exported.

Then let's export it. We don't work around kernel APIs or lack of. We fix them.


Rob
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux