On Tue, Feb 12, 2019 at 11:43:58AM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@xxxxxxxxxxxx>
>
> Its use was removed in an earlier commit, but it is still hanging
> around.
>
> Fixes: e00fb8564ee9 ("drm: Stop updating plane->crtc/fb/old_fb on atomic drivers")
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Sinclair Yeh <syeh@xxxxxxxxxx>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> Cc: Sean Paul <sean@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index c53ecbd9abddd..460509ef180a6 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -3031,8 +3031,7 @@ int __drm_atomic_helper_set_config(struct drm_mode_set *set,
> }
>
> static int __drm_atomic_helper_disable_all(struct drm_device *dev,
> - struct drm_modeset_acquire_ctx *ctx,
> - bool clean_old_fbs)
> + struct drm_modeset_acquire_ctx *ctx)
And I just realized the arguments exactly mirror
drm_atomic_helper_disable_all(), so I'll spin a new patch to remove the '__' and unify the useless wrapper.
Sean
> {
> struct drm_atomic_state *state;
> struct drm_connector_state *conn_state;
> @@ -3117,7 +3116,7 @@ static int __drm_atomic_helper_disable_all(struct drm_device *dev,
> int drm_atomic_helper_disable_all(struct drm_device *dev,
> struct drm_modeset_acquire_ctx *ctx)
> {
> - return __drm_atomic_helper_disable_all(dev, ctx, false);
> + return __drm_atomic_helper_disable_all(dev, ctx);
> }
> EXPORT_SYMBOL(drm_atomic_helper_disable_all);
>
> @@ -3139,7 +3138,7 @@ void drm_atomic_helper_shutdown(struct drm_device *dev)
>
> DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret);
>
> - ret = __drm_atomic_helper_disable_all(dev, &ctx, true);
> + ret = __drm_atomic_helper_disable_all(dev, &ctx);
> if (ret)
> DRM_ERROR("Disabling all crtc's during unload failed with %i\n", ret);
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
