| What | Removed | Added |
|---|---|---|
| Status | NEW | RESOLVED |
| Resolution | --- | FIXED |
Comment # 1
on bug 109587
from Eero Tamminen
Fixed by: ----------------------------------------------------- commit eba6609b7bee5a56fa5334992b1e6f3aef8d244a Author: Eric Engestrom <eric.engestrom@intel.com> Date: Fri Feb 8 14:46:07 2019 +0000 xf86drm: fix return type for drmIsMaster() Xserver has struct members named `bool`, which means the last commit breaks its build with errors like this: error: two or more data types in declaration specifiers Bool bool; ^ Fix this by making it return a 0/1 integer, with the same semantic as the boolean it was before. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109587 Fixes: 17dfe3ac93217b43f93b "xf86drm: Add drmIsMaster()" Cc: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> ----------------------------------------------------- I hope somebody fixes also those X server xf86Opt.h & winconfig.h headers soon as even some of X server code itself is using stdbool.h: ----------------------------------------------------- $ git grep stdbool.h hw/xquartz/GL/capabilities.h:#include <stdbool.h> hw/xquartz/mach-startup/bundle-main.c:#include <stdbool.h> hw/xwin/winmultiwindowicons.c:#include <stdbool.h> test/damage/primitives.c:#include <stdbool.h> test/simple-xinit.c:#include <stdbool.h> -----------------------------------------------------
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
