Re: [PATCH 2/8] drm: WARN() when drm_connector_attach_property fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 29 Mar 2012 18:27:20 -0300, Paulo Zanoni <przanoni@xxxxxxxxx> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> 
> Also return void instead of int. We have more than 100 callers and
> no one checks for the return value.
> 
> If this function fails the property won't be exposed by the get/set
> ioctls, but we should probably survive. If this starts happening,
> the solution will be to increase DRM_CONNECTOR_MAX_PROPERTY and
> recompile the Kernel.

Please add that to the error message and use printk_once() since we only
really want to annoy the user the first time.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux