Re: [PATCH libdrm] xf86drm: fix return type for drmIsMaster()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 8 Feb 2019 at 16:51, Daniel Stone <daniel@xxxxxxxxxxxxx> wrote:
>
> Hi Eric,
>
> On Fri, 8 Feb 2019 at 15:03, Eric Engestrom <eric.engestrom@xxxxxxxxx> wrote:
> > Xserver has struct members named `bool`, which means the last commit
> > breaks its build with errors like this:
> >
> >   error: two or more data types in declaration specifiers
> >   Bool bool;
> >        ^
> >
> > Fix this by making it return a 0/1 integer, with the same semantic as
> > the boolean it was before.
>
> Don't you need to drop the stdbool.h include for this to fix compilation?
>
Thanks Eric. With Dan's comment
Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

I really wonder if we cannot fix these trivial X nuisances? As-is
every project used has to either work around X mistakes :-(
Wrt libdrm that is fine, yet other projects might be less happy.

Thanks
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux