Re: [PATCH] drm/sched: Always trace the dependencies we wait on, to fix a race.

Christian König <ckoenig.leichtzumerken@xxxxxxxxx> · Fri, 8 Feb 2019 09:43:04 +0100

    Am 08.02.19 um 00:10 schrieb Eric
      Anholt:

      "Koenig, Christian" <Christian.Koenig@xxxxxxx> writes:

        Am 07.12.18 um 20:16 schrieb Eric Anholt:

          The entity->dependency can go away completely once we've called
drm_sched_entity_add_dependency_cb() (if the cb is called before we
get around to tracing).  The tracepoint is more useful if we trace
every dependency instead of just ones that get callbacks installed,
anyway, so just do that.

Fixes any easy-to-produce OOPS when tracing the scheduler on V3D with
"perf record -a -e gpu_scheduler:.\* glxgears" and DEBUG_SLAB enabled.

Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>

        Reviewed-by: Christian König <christian.koenig@xxxxxxx>

Going to pick that up for upstream and will add with a CC: stable.

      Looks like this got misplaced.

    My fault, pushed to our internal branch now with a CC: stable tag on
    it.

    Christian.

      _______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel