On Thu, Jan 31, 2019 at 08:26:00PM +0100, Sam Ravnborg wrote: > Hi Thierry et al. > > While reviewing a number of new panel drivers there was a > certain pattern in the feedback: > - the now deprecated drmP.h file was used > - dev_err() and friends was used > > This patch-set address the above items in the panel > drivers in drm/panel/ > The hope is that new panel drivers will no longer inherit bad > patterns from the existing drivers. > > The use of DRM_DEV* is not accepted by everyone, so this conversion > was split up in smaller bits. > If some drivers do not want to use DRM_DEV* then just drop the relevant patch. > > All patches are build tested on x86/arm. > > The DRM_DEV* patches depends on the drmP.h removal. > > One extra patch sneaked in "panel-innolux: drop unused variable" > This is a fix for an unused variable and was added to flush my panel patches. > > Note: Waiting for key storage (for gpg key) before I start the process getting > commit rights, so I rely on someone else (Thierry?) to commit this. > > Patches are made on top of drm-misc-next as of a few days ago. > > Comments welcome! Hey Sam, Thanks for the patchset, this will make dmesg grepping easier! One comment, and you're going to hate me for it: Why use DRM_DEV* instead of DRM_*? When I introduced DRM_DEV, it was to cover the case where there are multiple instances of the same driver (ie: dual-channel mipi, multiple crtcs, etc). I suppose that _could_ happen in the panel space, but it seems more unlikely than not. It's quite possible I'm overthinking this, but just something I figured I would point out. Either way, I think this is an improvement over dev_*. Sean > > Sam > > Sam Ravnborg (19): > drm/panel: drop drmP.h usage > drm/panel: panel-innolux: drop unused variable > drm/panel: samsung: use DRM_DEV* > drm/panel: arm-versatile: use DRM_DEV* > drm/panel: truly: use DRM_DEV* > drm/panel: sitronix: use DRM_DEV* > drm/panel: ilitek: use DRM_DEV* > drm/panel: innolux: use DRM_DEV* > drm/panel: jdi: use DRM_DEV* > drm/panel: lg: use DRM_DEV* > drm/panel: lvds: use DRM_DEV* > drm/panel: olimex: use DRM_DEV* > drm/panel: orisetech: use DRM_DEV* > drm/panel: panasonic: use DRM_DEV* > drm/panel: raspberrypi: use DRM_DEV* > drm/panel: raydium: use DRM_DEV* > drm/panel: seiko: use DRM_DEV* > drm/panel: sharp: use DRM_DEV* > drm/panel: simple: use DRM_DEV* > > drivers/gpu/drm/panel/panel-arm-versatile.c | 21 +++-- > drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 97 ++++++++++++---------- > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 14 ++-- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 17 ++-- > drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 66 ++++++++------- > drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c | 4 +- > drivers/gpu/drm/panel/panel-lg-lg4573.c | 25 +++--- > drivers/gpu/drm/panel/panel-lvds.c | 39 +++++---- > drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 28 ++++--- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 15 ++-- > .../gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 19 +++-- > .../gpu/drm/panel/panel-raspberrypi-touchscreen.c | 25 +++--- > drivers/gpu/drm/panel/panel-raydium-rm68200.c | 11 ++- > drivers/gpu/drm/panel/panel-samsung-ld9040.c | 18 ++-- > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 21 +++-- > drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 15 ++-- > drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 32 ++++--- > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 18 ++-- > drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 66 ++++++++++----- > drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 27 +++--- > drivers/gpu/drm/panel/panel-simple.c | 22 +++-- > drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 16 ++-- > drivers/gpu/drm/panel/panel-truly-nt35597.c | 10 ++- > 23 files changed, 375 insertions(+), 251 deletions(-) -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
