Re: [PATCH 4/5] drm/i2c: tda998x: add vendor specific infoframe support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 25, 2019 at 09:43:24AM +0000, Russell King wrote:
> Add support for the vendor specific infoframe.
> 
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>

LGTM.

Reviewed-by: Brian Starkey <brian.starkey@xxxxxxx>

> ---
>  drivers/gpu/drm/i2c/tda998x_drv.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index dad7396ebe2b..b0ed2ef49c62 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -874,6 +874,19 @@ tda998x_write_avi(struct tda998x_priv *priv, const struct drm_display_mode *mode
>  	tda998x_write_if(priv, DIP_IF_FLAGS_IF2, REG_IF2_HB0, &frame);
>  }
>  
> +static void tda998x_write_vsi(struct tda998x_priv *priv,
> +			      struct drm_display_mode *mode)
> +{
> +	union hdmi_infoframe frame;
> +
> +	if (drm_hdmi_vendor_infoframe_from_display_mode(&frame.vendor.hdmi,
> +							&priv->connector,
> +							mode))
> +		reg_clear(priv, REG_DIP_IF_FLAGS, DIP_IF_FLAGS_IF1);
> +	else
> +		tda998x_write_if(priv, DIP_IF_FLAGS_IF1, REG_IF1_HB0, &frame);
> +}
> +
>  /* Audio support */
>  
>  static void tda998x_audio_mute(struct tda998x_priv *priv, bool on)
> @@ -1572,6 +1585,7 @@ static void tda998x_bridge_mode_set(struct drm_bridge *bridge,
>  
>  		tda998x_write_avi(priv, adjusted_mode);
>  		tda998x_write_spd(priv);
> +		tda998x_write_vsi(priv, adjusted_mode);
>  
>  		if (priv->audio_params.format != AFMT_UNUSED &&
>  		    priv->sink_has_audio)
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux